github-mirrors/opencode-agentic-platform-engineering

Fork 0

mirror of https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering.git synced 2026-09-13 23:53:31 +02:00

[PR #13] [MERGED] feat: test-the-product suite, /update template sync, azure-policy-baseline + governance remediation #14

New issue

Closed

opened 2026-08-09 19:08:28 +02:00 by zaph0d · 0 comments

zaph0d commented

2026-08-09 19:08:28 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/pull/13
Author: @niels-emmer
Created: 7/3/2026
Status: ✅ Merged
Merged: 7/3/2026
Merged by: @niels-emmer

Base: main ← Head: feature/integrate-value-adds

📝 Commits (10+)

c7d0bd2 ci: add Azure DevOps static validation pipeline
7e65293 Updated README.md
648d03f docs(runbook): add drift detection guidance
051f135 docs: add value-adds implementation plan (epics 4-6)
3d397b1 test: add pytest suite for Python tooling and wire into CI (Epic 4A)
bc21250 test: add provider-mocked module tests for all IaC modules and run them in CI (Epic 4C)
912a4ff ci: add end-to-end scaffold verification matrix (Epic 4B)
4975755 docs: journal Epic 4 completion
818bb6f feat: /update — template sync for scaffolded repositories (Epic 5)
4bfd318 docs: journal Epic 5 completion

📊 Changes

69 files changed (+3804 additions, -26 deletions)

View changed files

📝 .github/workflows/ci.yml (+117 -0)
📝 .gitignore (+4 -0)
📝 AGENTS.md (+1 -0)
📝 BUILD_JOURNAL.md (+83 -0)
📝 BUILD_PLAN.md (+3 -0)
📝 DISCOVERIES_LOG.md (+19 -0)
📝 README.md (+15 -0)
➕ REMEDIATION_PLAN.md (+435 -0)
➕ VALUE_ADDS_PLAN.md (+445 -0)
📝 azure-pipelines.yml (+86 -0)
📝 docs/architecture-blueprint.md (+17 -0)
📝 docs/compliance-mapping-guide.md (+8 -0)
➕ docs/drift-runbook.md (+120 -0)
📝 docs/operator-manual-provisioned-platform.md (+13 -0)
📝 modules/bicep/azure-keyvault/v1/README.md (+13 -0)
📝 modules/bicep/azure-keyvault/v1/main.bicep (+23 -0)
📝 modules/bicep/azure-keyvault/v1/tests/main.test.bicep (+12 -0)
📝 modules/bicep/azure-network-baseline/v1/README.md (+9 -0)
📝 modules/bicep/azure-network-baseline/v1/main.bicep (+14 -1)
➕ modules/bicep/azure-network-baseline/v1/tests/main.test.bicep (+22 -0)

...and 49 more files

📄 Description

Summary

Integrates four bodies of work (built per the committed VALUE_ADDS_PLAN.md and REMEDIATION_PLAN.md) with the current main (epics 2–3, team packs):

Epic 4 — Test the Product

53-test pytest suite over the scaffolding engine, validators, and model selector (tests/, requirements-dev.txt)
Provider-mocked terraform test suites for all Terraform modules + compile-check Bicep test files; executed by both CI platforms
E2E scaffold verification: 4-combo matrix generates real workspaces and validates placeholders, configs, and rendered IaC
Fixes found by the new tests: invalid ACA subnet delegation action (hidden behind count = 0); scaffold.py shipping .terraform provider binaries into scaffolds

Epic 5 — `/update` template sync

Every scaffold stamped with .platform-scaffold.json (template commit, inputs, sha256 manifest)
scripts/update.py (shipped into scaffolds): three-way classification, auto-applies untouched files, preserves local edits, flags conflicts for agent-assisted merge
update skill + /update command in the template config

Epic 6 — `azure-policy-baseline`

Dual-stack module assigning six built-in Azure Policy definitions at subscription scope (GUIDs verified against Microsoft Learn), wired into both composed templates; Audit-by-default with Deny/DoNotEnforce controls

Governance remediation (all 5 audit findings)

Key Vault module diagnostics; AppGW autoscale; parameterized max_replicas; env-aware Log Analytics retention/quota; conservative runner sizing defaults with explicit prod overrides

Integration extras

Upstream tests/test_team_packs.py (25 tests) now actually runs in CI via the pytest step — 78 tests total
Fix: scaffold.py now copies scripts/team_packs.py into scaffolds (the template /pack-* commands referenced it but it was never shipped)
New CI jobs aligned to bumped action versions (checkout@v7, setup-python@v6, setup-terraform@v4)

Verification

ruff, byte-compile, validate-skills, validate-team, pack validation, 78 pytest tests, terraform fmt/validate/test (all 5 modules, mocked provider), all Bicep module+test builds, and the full 4-combo E2E scaffold matrix — all green locally.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/pull/13 **Author:** [@niels-emmer](https://github.com/niels-emmer) **Created:** 7/3/2026 **Status:** ✅ Merged **Merged:** 7/3/2026 **Merged by:** [@niels-emmer](https://github.com/niels-emmer) **Base:** `main` ← **Head:** `feature/integrate-value-adds` --- ### 📝 Commits (10+) - [`c7d0bd2`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/c7d0bd253e9cc09200ee2a97e3d7f31191d3ae53) ci: add Azure DevOps static validation pipeline - [`7e65293`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/7e65293187774149964d665bc62dacfbcbd99c0b) Updated README.md - [`648d03f`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/648d03fe1db453c55a7d214d7c090cc7e8c3343a) docs(runbook): add drift detection guidance - [`051f135`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/051f13539016a1fa49a52c3c2a99a0d2c145bd5b) docs: add value-adds implementation plan (epics 4-6) - [`3d397b1`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/3d397b1e19c560b8042020bc1ccc019b2625788e) test: add pytest suite for Python tooling and wire into CI (Epic 4A) - [`bc21250`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/bc21250a0e9137e4761302ea555af695a5c392e6) test: add provider-mocked module tests for all IaC modules and run them in CI (Epic 4C) - [`912a4ff`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/912a4ffba8eb1cd3abd39fa6a5361590d0787686) ci: add end-to-end scaffold verification matrix (Epic 4B) - [`4975755`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/4975755d5686f8da41609c85e19cd7792b0946e5) docs: journal Epic 4 completion - [`818bb6f`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/818bb6f44ff2bf276d27152f51df9762d9d3064b) feat: /update — template sync for scaffolded repositories (Epic 5) - [`4bfd318`](https://github.com/Team-Rockstars-AI/opencode-agentic-platform-engineering/commit/4bfd31806613cf1061ed918882339e7dddf40a72) docs: journal Epic 5 completion ### 📊 Changes **69 files changed** (+3804 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+117 -0) 📝 `.gitignore` (+4 -0) 📝 `AGENTS.md` (+1 -0) 📝 `BUILD_JOURNAL.md` (+83 -0) 📝 `BUILD_PLAN.md` (+3 -0) 📝 `DISCOVERIES_LOG.md` (+19 -0) 📝 `README.md` (+15 -0) ➕ `REMEDIATION_PLAN.md` (+435 -0) ➕ `VALUE_ADDS_PLAN.md` (+445 -0) 📝 `azure-pipelines.yml` (+86 -0) 📝 `docs/architecture-blueprint.md` (+17 -0) 📝 `docs/compliance-mapping-guide.md` (+8 -0) ➕ `docs/drift-runbook.md` (+120 -0) 📝 `docs/operator-manual-provisioned-platform.md` (+13 -0) 📝 `modules/bicep/azure-keyvault/v1/README.md` (+13 -0) 📝 `modules/bicep/azure-keyvault/v1/main.bicep` (+23 -0) 📝 `modules/bicep/azure-keyvault/v1/tests/main.test.bicep` (+12 -0) 📝 `modules/bicep/azure-network-baseline/v1/README.md` (+9 -0) 📝 `modules/bicep/azure-network-baseline/v1/main.bicep` (+14 -1) ➕ `modules/bicep/azure-network-baseline/v1/tests/main.test.bicep` (+22 -0) _...and 49 more files_ </details> ### 📄 Description ## Summary Integrates four bodies of work (built per the committed [VALUE_ADDS_PLAN.md](../blob/feature/integrate-value-adds/VALUE_ADDS_PLAN.md) and [REMEDIATION_PLAN.md](../blob/feature/integrate-value-adds/REMEDIATION_PLAN.md)) with the current main (epics 2–3, team packs): ### Epic 4 — Test the Product - 53-test pytest suite over the scaffolding engine, validators, and model selector (`tests/`, `requirements-dev.txt`) - Provider-mocked `terraform test` suites for **all** Terraform modules + compile-check Bicep test files; executed by both CI platforms - E2E scaffold verification: 4-combo matrix generates real workspaces and validates placeholders, configs, and rendered IaC - Fixes found by the new tests: invalid ACA subnet delegation action (hidden behind `count = 0`); `scaffold.py` shipping `.terraform` provider binaries into scaffolds ### Epic 5 — `/update` template sync - Every scaffold stamped with `.platform-scaffold.json` (template commit, inputs, sha256 manifest) - `scripts/update.py` (shipped into scaffolds): three-way classification, auto-applies untouched files, preserves local edits, flags conflicts for agent-assisted merge - `update` skill + `/update` command in the template config ### Epic 6 — `azure-policy-baseline` - Dual-stack module assigning six built-in Azure Policy definitions at subscription scope (GUIDs verified against Microsoft Learn), wired into both composed templates; Audit-by-default with Deny/DoNotEnforce controls ### Governance remediation (all 5 audit findings) - Key Vault module diagnostics; AppGW autoscale; parameterized `max_replicas`; env-aware Log Analytics retention/quota; conservative runner sizing defaults with explicit prod overrides ### Integration extras - Upstream `tests/test_team_packs.py` (25 tests) now actually runs in CI via the pytest step — 78 tests total - Fix: `scaffold.py` now copies `scripts/team_packs.py` into scaffolds (the template `/pack-*` commands referenced it but it was never shipped) - New CI jobs aligned to bumped action versions (checkout@v7, setup-python@v6, setup-terraform@v4) ## Verification `ruff`, byte-compile, `validate-skills`, `validate-team`, pack validation, 78 pytest tests, `terraform fmt`/`validate`/`test` (all 5 modules, mocked provider), all Bicep module+test builds, and the full 4-combo E2E scaffold matrix — all green locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zaph0d

2026-08-09 19:08:28 +02:00

closed this issue
added the
pull-request
label

zaph0d referenced this issue

2026-08-10 19:09:13 +02:00

[PR #14] ci(deps): bump actions/checkout from 6 to 7 #13

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

github-mirrors/opencode-agentic-platform-engineering#14

No description provided.

Rows
Columns