[PR #102] [MERGED] test: add regression coverage for category count reset bug #102

Closed
opened 2026-08-15 07:30:13 +02:00 by zaph0d · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/niels-emmer/myace/pull/102
Author: @niels-emmer
Created: 8/14/2026
Status: Merged
Merged: 8/14/2026
Merged by: @niels-emmer

Base: mainHead: test/category-count-regression


📝 Commits (1)

  • dc01244 test: add regression coverage for category count reset bug (#51)

📊 Changes

1 file changed (+50 additions, -0 deletions)

View changed files

📝 frontend/src/pages/CollectionDetail.test.tsx (+50 -0)

📄 Description

Summary

  • Investigated a user-reported recurrence of the category-count-shows-0 bug in Collections detail view.
  • Confirmed the fix from #51 is intact in CollectionDetail.tsxtypeCounts is computed from the full unfiltered artifact list, not the filtered one. Root cause of the recurrence was a stale cached SPA shell in the browser (the same class of issue #99 just fixed for the zip-download bug), not a code regression.
  • Adds a regression test locking in the #51 fix so it can't silently break again.

Test plan

  • npx vitest run src/pages/CollectionDetail.test.tsx — 15/15 pass, including the new "Category counts" test
  • npm run lint — clean (pre-existing unrelated warnings only)

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/niels-emmer/myace/pull/102 **Author:** [@niels-emmer](https://github.com/niels-emmer) **Created:** 8/14/2026 **Status:** ✅ Merged **Merged:** 8/14/2026 **Merged by:** [@niels-emmer](https://github.com/niels-emmer) **Base:** `main` ← **Head:** `test/category-count-regression` --- ### 📝 Commits (1) - [`dc01244`](https://github.com/niels-emmer/myace/commit/dc012446150816b4f90ce1b5ef6f21cc8d8566ff) test: add regression coverage for category count reset bug (#51) ### 📊 Changes **1 file changed** (+50 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/CollectionDetail.test.tsx` (+50 -0) </details> ### 📄 Description ## Summary - Investigated a user-reported recurrence of the category-count-shows-0 bug in Collections detail view. - Confirmed the fix from #51 is intact in `CollectionDetail.tsx` — `typeCounts` is computed from the full unfiltered artifact list, not the filtered one. Root cause of the recurrence was a stale cached SPA shell in the browser (the same class of issue #99 just fixed for the zip-download bug), not a code regression. - Adds a regression test locking in the #51 fix so it can't silently break again. ## Test plan - [x] `npx vitest run src/pages/CollectionDetail.test.tsx` — 15/15 pass, including the new "Category counts" test - [x] `npm run lint` — clean (pre-existing unrelated warnings only) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zaph0d 2026-08-15 07:30:13 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
github-mirrors/myace#102
No description provided.