github-mirrors/myace
1
0
Fork 0
mirror of https://github.com/niels-emmer/myace.git synced 2026-09-13 23:53:30 +02:00
Code Issues 4 Projects Releases 10 Packages Wiki Activity

[PR #147] [MERGED] fix: complete handoff_to metadata, add Database & QA collections, fix name collisions #147

New issue
Closed
opened 2026-09-02 07:34:53 +02:00 by zaph0d · 0 comments
zaph0d commented 2026-09-02 07:34:53 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/niels-emmer/myace/pull/147
Author: @niels-emmer
Created: 9/1/2026
Status: ✅ Merged
Merged: 9/1/2026
Merged by: @niels-emmer

Base: main ← Head: fix/base-profile-handoff-metadata

📝 Commits (6)

  • bf2b238 fix: add handoff_to metadata to base profile agents and seed opencode.json
  • 196db30 test: guard base-profile orchestration integrity at compile time
  • d846534 docs: clarify starter collection descriptions shown in the UI
  • b5f3e1b feat: add handoff_to metadata to additional collections, fix name collisions, add database and QA collections
  • 7b1cb63 test: guard additional collections compile clean on software-engineer
  • 79e0d11 docs: plan pre-compile name-collision preview in Profile Composer

📊 Changes

56 files changed (+847 additions, -84 deletions)

View changed files

📝 README.md (+17 -16)
📝 backend/app/services/seed_collections.py (+81 -55)
📝 backend/tests/test_artifact_create.py (+5 -0)
📝 backend/tests/test_profiles.py (+69 -0)
📝 backend/tests/test_seed_collections.py (+138 -0)
📝 collections/additional/ai-engineering/agents/ai-engineer.md (+1 -0)
📝 collections/additional/ai-engineering/agents/context-manager.md (+1 -0)
📝 collections/additional/ai-engineering/agents/prompt-engineer.md (+1 -0)
📝 collections/additional/android-developer/AGENTS.md (+1 -1)
📝 collections/additional/android-developer/agents/android-builder.md (+1 -0)
📝 collections/additional/android-developer/agents/android-reviewer.md (+1 -0)
📝 collections/additional/auditor/agents/compliance-reviewer.md (+1 -0)
📝 collections/additional/auditor/agents/security-compliance-auditor.md (+1 -0)
📝 collections/additional/aws/AGENTS.md (+3 -3)
📝 collections/additional/azure/AGENTS.md (+3 -3)
📝 collections/additional/backend/agents/api-reviewer.md (+1 -0)
📝 collections/additional/backend/agents/backend-builder.md (+1 -0)
➕ collections/additional/database/AGENTS.md (+25 -0)
➕ collections/additional/database/agents/data-reviewer.md (+27 -0)
➕ collections/additional/database/agents/schema-builder.md (+30 -0)

...and 36 more files

📄 Description

What does this change?

Completes the orchestration metadata work across all starter collections and
adds two missing specialist collections, plus a plan for a follow-up feature.

1. handoff_to metadata for all additional collections (rule 34).
All 27 agents across the 17 additional collections now carry machine-readable
handoff_to frontmatter matching their existing prose — including
cross-collection references to base software-engineer agents (verifier,
security-auditor, code-reviewer) that resolve at compile time. Previously
these agents described routing in prose but never surfaced as orchestration
recipes in the gallery.

2. Two new missing collections.

  • Database Specialist (database) — schema/query/migration discipline,
    schema-builder/data-reviewer agents, 3 skills.
  • QA / Test Engineer (qa-testing) — test strategy/automation/regression,
    test-builder/test-reviewer agents, 3 skills.

3. Fixed 6 pre-existing rule-29 name collisions (verified pre-existing on
main): within-collection skill/rule collisions in ios/android/java-spring,
and cross-collection cloud rule collisions (vendor-prefixed Security By Default/Cost Attribution/Governance By Design (CAF) in aws/azure/gcp/
scaleway).

4. Regression guards. New tests compile every base profile standalone and
every additional collection layered on software-engineer, asserting zero
dangling_handoff/name_collision warnings.

5. Clarified all 20 collection descriptions shown in the UI (who it's for

  • what it gives you, plain language).

6. Plan for a follow-up feature (docs/plans/pre-compile-collision-preview.md):
surface rule-29 name collisions at profile-edit time instead of compile time.
To be executed on its own branch after this merges.

Related issue

N/A

Type of change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing behavior to change)
  • Documentation only
  • Chore / refactor

How was this tested?

  • cd backend && pytest — 355 passed (up from 351; 4 new tests)
  • cd backend && ruff check — clean on all changed files
  • Verified zero name collisions across all 22 collections and zero dangling
    handoffs for every additional collection layered on software-engineer
  • cd frontend && vitest run on orchestration tests — 9 passed (unchanged)

Checklist

  • I read CONTRIBUTING.md
  • Tests pass locally (pytest / npm run test / npx tsc -b as applicable)
  • I added tests for new behavior, or explained why none are needed
  • Schema changes include an Alembic migration with a working downgrade()
  • I updated README.md, AGENTS.md/CLAUDE.md, and/or docs/ if this
    change affects what they document

Note on deployment

Per rule 25, the new collections and content edits only reach fresh seeds
(or after deleting affected starter rows on an existing install) — the
(name, is_starter_pack) idempotency short-circuits on already-seeded
collections.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/niels-emmer/myace/pull/147 **Author:** [@niels-emmer](https://github.com/niels-emmer) **Created:** 9/1/2026 **Status:** ✅ Merged **Merged:** 9/1/2026 **Merged by:** [@niels-emmer](https://github.com/niels-emmer) **Base:** `main` ← **Head:** `fix/base-profile-handoff-metadata` --- ### 📝 Commits (6) - [`bf2b238`](https://github.com/niels-emmer/myace/commit/bf2b23817f307d5c9003d540a333a54f6e0373b9) fix: add handoff_to metadata to base profile agents and seed opencode.json - [`196db30`](https://github.com/niels-emmer/myace/commit/196db3083570a7b4339fd5f02df731a1d12c6019) test: guard base-profile orchestration integrity at compile time - [`d846534`](https://github.com/niels-emmer/myace/commit/d8465343664d9a49374d5cbfe2f10af91475f5fc) docs: clarify starter collection descriptions shown in the UI - [`b5f3e1b`](https://github.com/niels-emmer/myace/commit/b5f3e1ba79852f38c79db928ba24add649e422d0) feat: add handoff_to metadata to additional collections, fix name collisions, add database and QA collections - [`7b1cb63`](https://github.com/niels-emmer/myace/commit/7b1cb631a0b9b6d897af4968993756f4fb226854) test: guard additional collections compile clean on software-engineer - [`79e0d11`](https://github.com/niels-emmer/myace/commit/79e0d11de13331789406e6dde187d8aab1047b6d) docs: plan pre-compile name-collision preview in Profile Composer ### 📊 Changes **56 files changed** (+847 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+17 -16) 📝 `backend/app/services/seed_collections.py` (+81 -55) 📝 `backend/tests/test_artifact_create.py` (+5 -0) 📝 `backend/tests/test_profiles.py` (+69 -0) 📝 `backend/tests/test_seed_collections.py` (+138 -0) 📝 `collections/additional/ai-engineering/agents/ai-engineer.md` (+1 -0) 📝 `collections/additional/ai-engineering/agents/context-manager.md` (+1 -0) 📝 `collections/additional/ai-engineering/agents/prompt-engineer.md` (+1 -0) 📝 `collections/additional/android-developer/AGENTS.md` (+1 -1) 📝 `collections/additional/android-developer/agents/android-builder.md` (+1 -0) 📝 `collections/additional/android-developer/agents/android-reviewer.md` (+1 -0) 📝 `collections/additional/auditor/agents/compliance-reviewer.md` (+1 -0) 📝 `collections/additional/auditor/agents/security-compliance-auditor.md` (+1 -0) 📝 `collections/additional/aws/AGENTS.md` (+3 -3) 📝 `collections/additional/azure/AGENTS.md` (+3 -3) 📝 `collections/additional/backend/agents/api-reviewer.md` (+1 -0) 📝 `collections/additional/backend/agents/backend-builder.md` (+1 -0) ➕ `collections/additional/database/AGENTS.md` (+25 -0) ➕ `collections/additional/database/agents/data-reviewer.md` (+27 -0) ➕ `collections/additional/database/agents/schema-builder.md` (+30 -0) _...and 36 more files_ </details> ### 📄 Description ## What does this change? Completes the orchestration metadata work across all starter collections and adds two missing specialist collections, plus a plan for a follow-up feature. **1. `handoff_to` metadata for all additional collections (rule 34).** All 27 agents across the 17 additional collections now carry machine-readable `handoff_to` frontmatter matching their existing prose — including cross-collection references to base software-engineer agents (`verifier`, `security-auditor`, `code-reviewer`) that resolve at compile time. Previously these agents described routing in prose but never surfaced as orchestration recipes in the gallery. **2. Two new missing collections.** - **Database Specialist** (`database`) — schema/query/migration discipline, `schema-builder`/`data-reviewer` agents, 3 skills. - **QA / Test Engineer** (`qa-testing`) — test strategy/automation/regression, `test-builder`/`test-reviewer` agents, 3 skills. **3. Fixed 6 pre-existing rule-29 name collisions** (verified pre-existing on `main`): within-collection skill/rule collisions in ios/android/java-spring, and cross-collection cloud rule collisions (vendor-prefixed `Security By Default`/`Cost Attribution`/`Governance By Design (CAF)` in aws/azure/gcp/ scaleway). **4. Regression guards.** New tests compile every base profile standalone and every additional collection layered on software-engineer, asserting zero `dangling_handoff`/`name_collision` warnings. **5. Clarified all 20 collection descriptions** shown in the UI (who it's for + what it gives you, plain language). **6. Plan for a follow-up feature** (`docs/plans/pre-compile-collision-preview.md`): surface rule-29 name collisions at profile-edit time instead of compile time. To be executed on its own branch after this merges. ## Related issue N/A ## Type of change - [x] Bug fix - [x] New feature - [ ] Breaking change (fix or feature that would cause existing behavior to change) - [x] Documentation only - [ ] Chore / refactor ## How was this tested? - `cd backend && pytest` — **355 passed** (up from 351; 4 new tests) - `cd backend && ruff check` — clean on all changed files - Verified zero name collisions across all 22 collections and zero dangling handoffs for every additional collection layered on software-engineer - `cd frontend && vitest run` on orchestration tests — 9 passed (unchanged) ## Checklist - [x] I read [`CONTRIBUTING.md`](../CONTRIBUTING.md) - [x] Tests pass locally (`pytest` / `npm run test` / `npx tsc -b` as applicable) - [x] I added tests for new behavior, or explained why none are needed - [ ] Schema changes include an Alembic migration with a working `downgrade()` - [x] I updated `README.md`, `AGENTS.md`/`CLAUDE.md`, and/or `docs/` if this change affects what they document ## Note on deployment Per rule 25, the new collections and content edits only reach **fresh** seeds (or after deleting affected starter rows on an existing install) — the `(name, is_starter_pack)` idempotency short-circuits on already-seeded collections. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zaph0d 2026-09-02 07:34:53 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dependabot/npm_and_yarn/frontend/vitest-5.0.0
dependabot/npm_and_yarn/frontend/frontend-deps-10fdd05a2f
dependabot/npm_and_yarn/frontend/tailwindcss-4.3.3
release/v1.11.0
fix/collection-detail-header-rows
fix/ui-layout-and-icons
dependabot/npm_and_yarn/frontend/lucide-react-1.33.0
feat/starter-collection-skills
feat/pre-compile-collision-preview
fix/base-profile-handoff-metadata
feat/eu-ai-act-compliance-collection
docs/readme-audit
docs/vendor-cloud-collections-plan
feat/inline-artifact-editing
feat/pi-dev-adapter
docs/mark-platform-enhancements-complete
feat/trust-onboarding
feat/orchestration-ux
feat/sync-drift-tooling
feat/compile-validation
v1.11.0
latest
v1.10.0
v1.9.0
v1.8.0
v1.3.0
v1.2.0
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v0.1-alpha
Labels
Clear labels   
backlog

   
good first issue

   
good first issue

   
help wanted

   
pull-request
Mirrored from GitHub Pull Request

No labels
backlog
good first issue
good first issue
help wanted
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
github-mirrors/myace#147
No description provided.