[PR #21] [MERGED] fix: move frontend port from base compose to dev compose #21

New issue

Closed

opened 2026-08-09 19:08:08 +02:00 by zaph0d · 0 comments

zaph0d commented

2026-08-09 19:08:08 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/niels-emmer/myace/pull/21
Author: @niels-emmer
Created: 8/9/2026
Status: ✅ Merged
Merged: 8/9/2026
Merged by: @niels-emmer

Base: main ← Head: fix/compose-port-conflict

📝 Commits (1)

4713e91 fix: move frontend port from base compose to dev compose

📊 Changes

2 files changed (+1 additions, -3 deletions)

View changed files

📝 docker-compose.prod.yml (+1 -1)
📝 docker-compose.yml (+0 -2)

📄 Description

Summary

Moves the frontend port mapping (80:80) from docker-compose.yml (base) to docker-compose.dev.yml (dev only). The base compose is used as a layer for both dev and prod deployments — having port 80 there causes conflicts on the VPS where another service already binds port 80.

Changes

docker-compose.yml: Removed ports: ["80:80"] from frontend service
docker-compose.dev.yml: Already had ports: ["80:80"] — no change needed
docker-compose.prod.yml: Already had ports: [] — no change needed

Testing

Dev: docker compose -f docker-compose.yml -f docker-compose.dev.yml up -d still exposes port 80
Prod: docker compose -f docker-compose.yml -f docker-compose.prod.yml up -d no longer conflicts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/niels-emmer/myace/pull/21 **Author:** [@niels-emmer](https://github.com/niels-emmer) **Created:** 8/9/2026 **Status:** ✅ Merged **Merged:** 8/9/2026 **Merged by:** [@niels-emmer](https://github.com/niels-emmer) **Base:** `main` ← **Head:** `fix/compose-port-conflict` --- ### 📝 Commits (1) - [`4713e91`](https://github.com/niels-emmer/myace/commit/4713e917c64c839ca3feae3f1a0dee28da51bddf) fix: move frontend port from base compose to dev compose ### 📊 Changes **2 files changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose.prod.yml` (+1 -1) 📝 `docker-compose.yml` (+0 -2) </details> ### 📄 Description ## Summary Moves the frontend port mapping (`80:80`) from `docker-compose.yml` (base) to `docker-compose.dev.yml` (dev only). The base compose is used as a layer for both dev and prod deployments — having port 80 there causes conflicts on the VPS where another service already binds port 80. ### Changes - `docker-compose.yml`: Removed `ports: ["80:80"]` from frontend service - `docker-compose.dev.yml`: Already had `ports: ["80:80"]` — no change needed - `docker-compose.prod.yml`: Already had `ports: []` — no change needed ### Testing - Dev: `docker compose -f docker-compose.yml -f docker-compose.dev.yml up -d` still exposes port 80 - Prod: `docker compose -f docker-compose.yml -f docker-compose.prod.yml up -d` no longer conflicts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zaph0d

2026-08-09 19:08:08 +02:00