[PR #95] [MERGED] Fix starter-collection content bugs and 6 broken compile adapters #95

New issue

Closed

opened 2026-08-15 07:30:12 +02:00 by zaph0d · 0 comments

zaph0d commented

2026-08-15 07:30:12 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/niels-emmer/myace/pull/95
Author: @niels-emmer
Created: 8/14/2026
Status: ✅ Merged
Merged: 8/14/2026
Merged by: @niels-emmer

Base: main ← Head: fix/starter-collections-and-adapter-audit

📝 Commits (2)

31c36b3 fix: correct starter-collection content bugs and 6 broken compile adapters
906c235 fix: satisfy ruff/mypy on the adapter fixes and verify against real CI tools

📊 Changes

103 files changed (+1251 additions, -454 deletions)

View changed files

📝 AGENTS.md (+36 -0)
📝 CLAUDE.md (+10 -4)
📝 README.md (+19 -11)
📝 backend/app/adapters/__init__.py (+0 -2)
📝 backend/app/adapters/claude_code.py (+46 -28)
📝 backend/app/adapters/cline.py (+28 -40)
📝 backend/app/adapters/codex_cli.py (+64 -22)
➖ backend/app/adapters/cody.py (+0 -52)
📝 backend/app/adapters/continue_dev.py (+24 -15)
📝 backend/app/adapters/cursor.py (+32 -45)
📝 backend/app/adapters/goose.py (+23 -17)
📝 backend/app/models/profile.py (+1 -1)
📝 backend/tests/test_adapters.py (+115 -105)
📝 collections/additional/android-developer/AGENTS.md (+1 -1)
📝 collections/additional/android-developer/agents/android-builder.md (+1 -1)
📝 collections/additional/android-developer/agents/android-reviewer.md (+1 -1)
📝 collections/additional/android-developer/skills/android-testing/SKILL.md (+3 -3)
📝 collections/additional/android-developer/skills/jetpack-compose-conventions/SKILL.md (+1 -1)
📝 collections/additional/android-developer/skills/play-store-readiness/SKILL.md (+1 -1)
📝 collections/additional/auditor/agents/compliance-reviewer.md (+4 -4)

...and 80 more files

📄 Description

Summary

A content-quality review of all 13 starter collections turned up a factual
error, three cross-collection name collisions, and a silently-swallowed
YAML parse bug — fixed, with a regression-style verification pass and new
AGENTS.md/docs/debugging.md entries so the collision class of bug is
documented and searchable.

That led into a docs-backed audit of all 12 compile adapters
(backend/app/adapters/*.py) against each target framework's current
live documentation, since several hadn't been re-verified since they were
first built. Result: 6 of 12 needed real fixes (not just staleness —
claude_code.py and cursor.py were broken badly enough that compiled
agents/rules likely weren't loading in the target tool at all), and one
(cody.py) was retired outright — its target format was never real, and
the product itself (Cody Free/Pro) was discontinued in 2025.

Separately, a user-reported bug ("preview shows many files, zip download
has only one big AGENTS.md") turned out to be an unrelated frontend issue —
the zip download read live dropdown state instead of the actual compiled
result, so changing the target dropdown after compiling (without
recompiling) silently changed what got zipped.

Changes

Starter collections (collections/)

Factual error: papaya → Paparazzi (real Compose screenshot-testing
tool), plus a deprecated coroutines-test API reference
3 cross-collection name collisions fixed by renaming the additional/
side (security-auditor→security-compliance-auditor,
docs-writer→technical-writer, Security Checklist→Security Audit Checklist), plus a 4th lower-risk one (Offline-First)
A silently-swallowed YAML frontmatter parse error in
swiftui-conventions (an unquoted @ broke the whole frontmatter block,
degrading name/priority/compatibility/description with no error)
copilot-cli added to all 81 compatibility lists; N-A→N/A
normalized; a stale claude-sonnet-4 reference updated

Compile adapters (backend/app/adapters/) — every fix cites the
current doc URL it was verified against; full writeup with before/after
per adapter in docs/ADAPTERS_RESEARCH.md and
docs/plans/starter-collections-improvements.md

claude_code.py: agents had no frontmatter (real subagents need
name/description to register at all); .claude/workflows/
.claude/models were invented paths — now .claude/skills/ (on-demand)
and .claude/commands/
cursor.py: wrong frontmatter fields entirely (real: description/
globs/alwaysApply) — a rule missing them risks not loading; dropped
legacy .cursorrules and invented workflow/model paths; named files
instead of numbered
codex_cli.py: agents should be TOML under .codex/agents/, not
Markdown; no "workflow" concept exists in Codex CLI at all;
config.toml's model schema was invented
cline.py: none of its frontmatter fields matched Cline's real schema
(only paths is real)
continue_dev.py, goose.py: one stale path each
cody.py retired — deleted, deregistered, removed from every
collection's compatibility list and from README.md/
docs/architecture.md/docs/ADAPTERS_RESEARCH.md

Frontend

TargetExporter.tsx's zip download now uses result.profile_id/
result.target (what's actually on screen) instead of live dropdown
state — with a regression test reproducing the exact mismatch scenario

Test plan

Backend: all changed adapters syntax-checked (py_compile) and
logic-traced against expected output shapes (this environment
doesn't have sqlmodel/pydantic installed, so the real
pytest tests/test_adapters.py suite should be run before merge)
Frontend: full vitest suite passing (19/19, including the new
zip-download regression test) and tsc -b --noEmit clean
Standalone script re-implementing the scanner + compile_profile()
dedup logic: 156 artifacts across all 13 collections parse with zero
YAML errors and zero cross-collection name collisions
Run cd backend && pytest tests/test_adapters.py -v for real before
merging — noted as the top follow-up in
docs/plans/starter-collections-improvements.md

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/niels-emmer/myace/pull/95 **Author:** [@niels-emmer](https://github.com/niels-emmer) **Created:** 8/14/2026 **Status:** ✅ Merged **Merged:** 8/14/2026 **Merged by:** [@niels-emmer](https://github.com/niels-emmer) **Base:** `main` ← **Head:** `fix/starter-collections-and-adapter-audit` --- ### 📝 Commits (2) - [`31c36b3`](https://github.com/niels-emmer/myace/commit/31c36b32d22ce98d6cefbf547b3280d66149c903) fix: correct starter-collection content bugs and 6 broken compile adapters - [`906c235`](https://github.com/niels-emmer/myace/commit/906c23516527c8a664160d67de3d4c1f96b20471) fix: satisfy ruff/mypy on the adapter fixes and verify against real CI tools ### 📊 Changes **103 files changed** (+1251 additions, -454 deletions) <details> <summary>View changed files</summary> 📝 `AGENTS.md` (+36 -0) 📝 `CLAUDE.md` (+10 -4) 📝 `README.md` (+19 -11) 📝 `backend/app/adapters/__init__.py` (+0 -2) 📝 `backend/app/adapters/claude_code.py` (+46 -28) 📝 `backend/app/adapters/cline.py` (+28 -40) 📝 `backend/app/adapters/codex_cli.py` (+64 -22) ➖ `backend/app/adapters/cody.py` (+0 -52) 📝 `backend/app/adapters/continue_dev.py` (+24 -15) 📝 `backend/app/adapters/cursor.py` (+32 -45) 📝 `backend/app/adapters/goose.py` (+23 -17) 📝 `backend/app/models/profile.py` (+1 -1) 📝 `backend/tests/test_adapters.py` (+115 -105) 📝 `collections/additional/android-developer/AGENTS.md` (+1 -1) 📝 `collections/additional/android-developer/agents/android-builder.md` (+1 -1) 📝 `collections/additional/android-developer/agents/android-reviewer.md` (+1 -1) 📝 `collections/additional/android-developer/skills/android-testing/SKILL.md` (+3 -3) 📝 `collections/additional/android-developer/skills/jetpack-compose-conventions/SKILL.md` (+1 -1) 📝 `collections/additional/android-developer/skills/play-store-readiness/SKILL.md` (+1 -1) 📝 `collections/additional/auditor/agents/compliance-reviewer.md` (+4 -4) _...and 80 more files_ </details> ### 📄 Description ## Summary A content-quality review of all 13 starter collections turned up a factual error, three cross-collection name collisions, and a silently-swallowed YAML parse bug — fixed, with a regression-style verification pass and new `AGENTS.md`/`docs/debugging.md` entries so the collision class of bug is documented and searchable. That led into a docs-backed audit of all 12 compile adapters (`backend/app/adapters/*.py`) against each target framework's *current* live documentation, since several hadn't been re-verified since they were first built. Result: **6 of 12 needed real fixes** (not just staleness — `claude_code.py` and `cursor.py` were broken badly enough that compiled agents/rules likely weren't loading in the target tool at all), and one (`cody.py`) was retired outright — its target format was never real, and the product itself (Cody Free/Pro) was discontinued in 2025. Separately, a user-reported bug ("preview shows many files, zip download has only one big AGENTS.md") turned out to be an unrelated frontend issue — the zip download read live dropdown state instead of the actual compiled result, so changing the target dropdown after compiling (without recompiling) silently changed what got zipped. ## Changes **Starter collections** (`collections/`) - Factual error: `papaya` → `Paparazzi` (real Compose screenshot-testing tool), plus a deprecated coroutines-test API reference - 3 cross-collection name collisions fixed by renaming the `additional/` side (`security-auditor`→`security-compliance-auditor`, `docs-writer`→`technical-writer`, `Security Checklist`→`Security Audit Checklist`), plus a 4th lower-risk one (`Offline-First`) - A silently-swallowed YAML frontmatter parse error in `swiftui-conventions` (an unquoted `@` broke the whole frontmatter block, degrading name/priority/compatibility/description with no error) - `copilot-cli` added to all 81 `compatibility` lists; `N-A`→`N/A` normalized; a stale `claude-sonnet-4` reference updated **Compile adapters** (`backend/app/adapters/`) — every fix cites the current doc URL it was verified against; full writeup with before/after per adapter in `docs/ADAPTERS_RESEARCH.md` and `docs/plans/starter-collections-improvements.md` - `claude_code.py`: agents had **no frontmatter** (real subagents need `name`/`description` to register at all); `.claude/workflows`/ `.claude/models` were invented paths — now `.claude/skills/` (on-demand) and `.claude/commands/` - `cursor.py`: wrong frontmatter fields entirely (real: `description`/ `globs`/`alwaysApply`) — a rule missing them risks not loading; dropped legacy `.cursorrules` and invented workflow/model paths; named files instead of numbered - `codex_cli.py`: agents should be TOML under `.codex/agents/`, not Markdown; no "workflow" concept exists in Codex CLI at all; `config.toml`'s model schema was invented - `cline.py`: none of its frontmatter fields matched Cline's real schema (only `paths` is real) - `continue_dev.py`, `goose.py`: one stale path each - `cody.py` **retired** — deleted, deregistered, removed from every collection's compatibility list and from `README.md`/ `docs/architecture.md`/`docs/ADAPTERS_RESEARCH.md` **Frontend** - `TargetExporter.tsx`'s zip download now uses `result.profile_id`/ `result.target` (what's actually on screen) instead of live dropdown state — with a regression test reproducing the exact mismatch scenario ## Test plan - [x] Backend: all changed adapters syntax-checked (`py_compile`) and logic-traced against expected output shapes (this environment doesn't have `sqlmodel`/`pydantic` installed, so the real `pytest tests/test_adapters.py` suite should be run before merge) - [x] Frontend: full `vitest` suite passing (19/19, including the new zip-download regression test) and `tsc -b --noEmit` clean - [x] Standalone script re-implementing the scanner + `compile_profile()` dedup logic: 156 artifacts across all 13 collections parse with zero YAML errors and zero cross-collection name collisions - [ ] Run `cd backend && pytest tests/test_adapters.py -v` for real before merging — noted as the top follow-up in `docs/plans/starter-collections-improvements.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zaph0d

2026-08-15 07:30:12 +02:00